Skip to content

ref(core): use shared MCP attribute conventions - #25059

Merged
betegon merged 3 commits into
developfrom
bt/mcp-conventions-imports
Oct 13, 2026
Merged

betegon merged 3 commits into
developfrom
bt/mcp-conventions-imports

Conversation

@betegon

@betegon betegon commented Oct 5, 2026 •

Copy link
Copy Markdown
Member

Use @sentry/conventions/attributes for registered MCP keys, including all singleton and indexed result fields. The branch now uses published conventions 0.27.0 from develop, so both local result prefixes can be removed.

Before, the SDK constructed mcp.tool.result.0.content from a local prefix. After, MCP_TOOL_RESULT_KEY_CONTENT.replace('<key>', '0') produces that same key. Singleton keys, values, original array indexes, and input/output capture behavior remain unchanged. Deprecated tool-result fields stay emitted for compatibility; this change adds no aliases or backfill.

This is the mechanical base for network metadata (#24506), OAuth attribution (#24508), and canonical OpenTelemetry attributes (#25060). The latter separately adds complete serialized results in gen_ai.tool.call.result.

@github-actions

github-actions Bot commented Oct 5, 2026 •

Copy link
Copy Markdown
Contributor

size-limit report 📦

Path Size % Change Change
@sentry/browser 29.83 kB - -
@sentry/browser - with treeshaking flags 27.96 kB - -
@sentry/browser - with treeshaking flags tracing without tracing 27.87 kB - -
@sentry/browser (incl. Tracing) 52.02 kB - -
@sentry/browser (incl. Tracing + Span Streaming) 52.02 kB - -
@sentry/browser (incl. Tracing, Profiling) 54.96 kB - -
@sentry/browser (incl. Tracing, Replay) 91.75 kB - -
@sentry/browser (incl. Tracing, Replay) - with treeshaking flags 80.62 kB - -
@sentry/browser (incl. Tracing, Replay with Canvas) 96.47 kB - -
@sentry/browser (incl. Tracing, Replay, Feedback) 109.43 kB - -
@sentry/browser (incl. Feedback) 47.35 kB - -
@sentry/browser (incl. sendFeedback) 34.89 kB - -
@sentry/browser (incl. FeedbackAsync) 40 kB - -
@sentry/browser (incl. Metrics) 30.85 kB - -
@sentry/browser (incl. Logs) 31.13 kB - -
@sentry/browser (incl. Metrics & Logs) 31.78 kB - -
@sentry/react 31.64 kB - -
@sentry/react (incl. Tracing) 54.34 kB - -
@sentry/vue 37.98 kB - -
@sentry/vue (incl. Tracing) 54.95 kB - -
@sentry/svelte 29.86 kB - -
@sentry/remix (Remix 3 client bundle) 57.02 kB - -
CDN Bundle 31.56 kB - -
CDN Bundle (incl. Tracing) 52.52 kB - -
CDN Bundle (incl. Logs, Metrics) 33.77 kB - -
CDN Bundle (incl. Tracing, Logs, Metrics) 54.46 kB - -
CDN Bundle (incl. Replay, Logs, Metrics) 74.7 kB - -
CDN Bundle (incl. Tracing, Replay) 90.19 kB - -
CDN Bundle (incl. Tracing, Replay, Logs, Metrics) 92.11 kB - -
CDN Bundle (incl. Tracing, Replay, Feedback) 96.34 kB - -
CDN Bundle (incl. Tracing, Replay, Feedback, Logs, Metrics) 98.28 kB - -
CDN Bundle - uncompressed 92.98 kB - -
CDN Bundle (incl. Tracing) - uncompressed 155.83 kB - -
CDN Bundle (incl. Logs, Metrics) - uncompressed 99.52 kB - -
CDN Bundle (incl. Tracing, Logs, Metrics) - uncompressed 161.79 kB - -
CDN Bundle (incl. Replay, Logs, Metrics) - uncompressed 229.56 kB - -
CDN Bundle (incl. Tracing, Replay) - uncompressed 276 kB - -
CDN Bundle (incl. Tracing, Replay, Logs, Metrics) - uncompressed 281.94 kB - -
CDN Bundle (incl. Tracing, Replay, Feedback) - uncompressed 289.7 kB - -
CDN Bundle (incl. Tracing, Replay, Feedback, Logs, Metrics) - uncompressed 295.63 kB - -
@sentry/nextjs (client) 56.75 kB - -
@sentry/sveltekit (client) 52.41 kB - -
@sentry/core/server 41.12 kB +0.32% +131 B 🔺
@sentry/core/browser 13.81 kB - -
@sentry/node 151.98 kB +0.02% +24 B 🔺
@sentry/node/import (ESM hook with diagnostics-channel injection) 83.78 kB - -
@sentry/node - without tracing 94.54 kB +0.01% +3 B 🔺
@sentry/node - without channel injection 130.18 kB +0.04% +47 B 🔺
@sentry/aws-serverless 102.69 kB +0.01% +6 B 🔺
@sentry/cloudflare (withSentry) - minified 210.38 kB - -
@sentry/cloudflare (withSentry) 521.61 kB - -
@sentry/nextjs/cloudflare (withSentry) - minified 228.06 kB - -

View base workflow run

@betegon
betegon marked this pull request as ready for review October 8, 2026 10:49
@betegon
betegon force-pushed the bt/mcp-conventions-imports branch from e6adecb to 6459be3 Compare October 8, 2026 10:49
@betegon
betegon requested review from JPeer264 and Lms24 October 8, 2026 11:04

@JPeer264 JPeer264 left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks for splitting this into its own PR. Btw is there a follow up planned for the ones which are not used by the conventions, such as MCP_TOOL_RESULT_PREFIX?

betegon commented Oct 8, 2026

Copy link
Copy Markdown
Member Author

i thought we couldn't do anything with prefixes / indexes. great call out, here it is: getsentry/sentry-conventions#689

@betegon
betegon force-pushed the bt/mcp-conventions-imports branch from 901e5c8 to a6f65bf Compare October 13, 2026 08:51
@betegon
betegon force-pushed the bt/mcp-conventions-imports branch from a6f65bf to 1afb158 Compare October 13, 2026 18:42
@betegon
betegon merged commit 51b1946 into develop Oct 13, 2026
371 checks passed
@betegon
betegon deleted the bt/mcp-conventions-imports branch October 13, 2026 18:58
renovate Bot added a commit to andrei-picus-tink/auto-renovate that referenced this pull request Oct 17, 2026
| datasource | package             | from  | to     |
| ---------- | ------------------- | ----- | ------ |
| npm        | @sentry/vite-plugin | 5.4.1 | 11.8.0 |


## [v11.8.0](https://github.com/getsentry/sentry-javascript/blob/HEAD/CHANGELOG.md#1180)

##### Important Changes

- **feat(bundler-plugins): Release `@sentry/webpack-plugin`, `@sentry/vite-plugin`, `@sentry/rollup-plugin` and `@sentry/esbuild-plugin` from the SDK repository ([#25095](getsentry/sentry-javascript#25095

  The four standalone bundler plugins now release together with the SDK, so their version jumps from 5.4.1 to the SDK version. Each package re-exports the matching `@sentry/bundler-plugins` entry point, which we recommend for new projects. The plugin options do not change, but the update brings these breaking changes:

  - Node.js 20.19.0 or higher is required.
  - `@sentry/webpack-plugin` requires webpack 5.1 or higher. The `@sentry/webpack-plugin/webpack5` entry point still works and exports the same plugin as `@sentry/webpack-plugin`.
  - The plugins use the `sentry` CLI SDK instead of `@sentry/cli`. Sentry self-hosted 26.4.2 or higher is supported. Lower versions may continue to work.
  - Deploys that the plugins create on Vercel use the value of `VERCEL_TARGET_ENV` (`production`, `preview` or a custom name) as their environment, instead of `vercel-production` or `vercel-preview`. To keep the old value, set `release.deploy.env`.

- **feat(server-utils): Instrument the OpenAI decisions API as `gen_ai.decide` spans ([#25285](getsentry/sentry-javascript#25285

  OpenAI `decisions.create` calls now create `gen_ai.decide` spans.

##### Other Changes

- feat(core): Support SuppressedError in LinkedErrors integration ([#25246](getsentry/sentry-javascript#25246))
- fix(astro): Delete generated source maps for static output ([#25310](getsentry/sentry-javascript#25310))
- fix(astro): Upload source maps of Astro 7's prerender build ([#25309](getsentry/sentry-javascript#25309))
- fix(browser): Apply `urlQueryParams` to the Referer header ([#25324](getsentry/sentry-javascript#25324))
- fix(cloudflare): auto-instrument when wrangler `main` is a package ([#25343](getsentry/sentry-javascript#25343))
- fix(hono): Expose runtime-specific SDK options ([#25290](getsentry/sentry-javascript#25290))
- fix(node): Instrument Prisma 8 CollectionBase from rc.15 ([#25301](getsentry/sentry-javascript#25301))
- fix(nuxt): Skip 3xx/4xx Nuxt errors in the vue:error hook ([#25341](getsentry/sentry-javascript#25341))
- fix(server-utils): Read pi-durable 1.2.0 tool results from `output` ([#25312](getsentry/sentry-javascript#25312))
- fix(server-utils): Transform modules once when two Sentry Vite plugins add orchestrion ([#25043](getsentry/sentry-javascript#25043))
- fix(sveltekit): add op and origin to Kit's `sveltekit.endpoint` span ([#25376](getsentry/sentry-javascript#25376))
- fix(tanstackstart-react): Keep parametrized route names in Nitro 3 builds ([#25307](getsentry/sentry-javascript#25307))
- fix(tanstackstart-react): Rewrite source paths of split route modules ([#25361](getsentry/sentry-javascript#25361))

<details>
  <summary> <strong>Internal Changes</strong> </summary>

- chore: Add external contributor to CHANGELOG.md ([#25375](getsentry/sentry-javascript#25375))
- ci: Install the pnpm version that Volta pins ([#25287](getsentry/sentry-javascript#25287))
- license: Add cli FSL notice to package licenses ([#25314](getsentry/sentry-javascript#25314))
- ref(core): use shared MCP attribute conventions ([#25059](getsentry/sentry-javascript#25059))
- ref(tanstackstart-react): Reuse shared component annotation options ([#25313](getsentry/sentry-javascript#25313))
- test(browser): Keep whitespace text out of the handlers-lcp page ([#25280](getsentry/sentry-javascript#25280))
- test(bun): Restore [@sentry/core](https://github.com/sentry/core) spies after the Bun.serve tests ([#25276](getsentry/sentry-javascript#25276))
- test(bundler-plugins): Disable CLI telemetry in the CLI contract tests ([#25308](getsentry/sentry-javascript#25308))
- test(e2e): Add node-openai-decisions-send-to-sentry test app ([#25331](getsentry/sentry-javascript#25331))
- test(e2e): Add node-openai-send-to-sentry test app ([#24824](getsentry/sentry-javascript#24824))
- test(e2e): Add nuxt-5-sourcemaps test ([#25268](getsentry/sentry-javascript#25268))
- test(e2e): Inherit root Volta config in all e2e test apps ([#25369](getsentry/sentry-javascript#25369))
- test(e2e): Use an external host address for the Lambda DSN on loopback hostnames ([#25282](getsentry/sentry-javascript#25282))
- test(nextjs): Run nextjs-16-tunnel on Cloudflare ([#25161](getsentry/sentry-javascript#25161))
- test(nextjs): Switch DEBUG_BUILD with a getter instead of re-importing the SDK ([#25279](getsentry/sentry-javascript#25279))
- test(node): Await the child exit in the "should exit" integration tests ([#25277](getsentry/sentry-javascript#25277))
- test(node): Cover ioredis v6 in the diagnostics_channel suite ([#25300](getsentry/sentry-javascript#25300))
- test(node): Cover LangChain model calls made from a tool without config ([#25326](getsentry/sentry-javascript#25326))
- test(node): Log slow and failed Docker Compose starts in integration tests ([#25278](getsentry/sentry-javascript#25278))
- test(node): Unflake captureMessage with_level test ([#25358](getsentry/sentry-javascript#25358))
- test(sveltekit): Pin rollup to 4.64.5 ([#25328](getsentry/sentry-javascript#25328))

</details>

Work in this release was contributed by [@kunal649](https://github.com/kunal649) and [@mketiku](https://github.com/mketiku). Thank you for your contributions!
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants