Repository navigation
fix(astro): Upload source maps of Astro 7's prerender build - #25309
Merged
Merged
Conversation
Lms24
added this pull request to stack #25311
October 13, 2026 08:29
Lms24
marked this pull request as ready for review
October 13, 2026 09:03
Lms24
requested review from
nicohrubec and
s1gr1d
and removed request for
a team
October 13, 2026 09:03
3 tasks done
s1gr1d
approved these changes
Oct 13, 2026
s1gr1d
left a comment
Member
There was a problem hiding this comment.
Just one question: Do we delete the source maps again in case only Sentry enabled them in .prerender?
Member
Author
Good question! In this case the answer is "not us", since Astro already deletes the .prerender folder after the build. Our globs, also after the update in, #25310 don't. Or rather didn't because I think we can just be a bit extra careful here and also add the |
Astro 7 writes the prerender build to a hidden `.prerender` folder, which the default `<outDir>/**/*` assets glob does not enter. The upload found no files and logged "Didn't find any matching sources for debug ID upload". Add an explicit `<outDir>/**/.prerender/**/*` glob to the defaults. Add an `astro-7-sourcemaps` e2e app that checks what gets uploaded for server and static output. Fixes #25304 Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com>
Lms24
force-pushed
the
lms/fix-astro-prerender-sourcemaps
branch
from
October 13, 2026 14:08
2499c99 to
9afeeb5
Compare
51 tasks done
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Astro 7 writes the prerender build to a hidden
.prerenderfolder, and our default<outDir>/**/*assets glob does not go into dot folders, so the upload found nothing and logged a warning. This PR adds<outDir>/**/.prerender/**/*to the default globs. These chunks only run at build time, so the gain is small, but it removes the warning and covers errors captured during prerendering. Also adds anastro-7-sourcemapse2e app that checks the uploads for server and static output. Fixes #25304