Repository navigation
Conversation
Signed-off-by: lazerg <lazerg2@gmail.com> Assisted-by: Claude Code
|
Review requested:
|
|
Caution AgentScan found account activity patterns that may be consistent with automation. This is a heuristic, not proof that this pull request was opened by an agent or violates policy. AI-assisted contributions are permitted, but automated tooling must not open pull requests without advance approval, and contributors must personally understand, test, verify, and take responsibility for every submitted change. See the AgentScan analysis, AI use policy, and automation policy for additional context. |
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #66659 +/- ##
==========================================
- Coverage 90.47% 90.46% -0.01%
==========================================
Files 791 791
Lines 277088 277092 +4
Branches 53276 53280 +4
==========================================
- Hits 250686 250682 -4
+ Misses 16813 16807 -6
- Partials 9589 9603 +14
🚀 New features to boost your workflow:
|
Signed-off-by: lazerg <lazerg2@gmail.com> Assisted-by: Claude Code
| return getOriginalSource(map, originalSourcePath); | ||
| } | ||
| } | ||
| } |
There was a problem hiding this comment.
If no section matches, could this fall through to ArrayPrototypeIndexOf(payload.sources, ...) and throw, since index maps have no top-level sources? Should we return undefined here? If so, a regression test for this case would also be helpful.
Signed-off-by: lazerg <lazerg2@gmail.com> Assisted-by: Claude Code
Fixes: #66657
sourcesToAbsolute()reads the top-levelsourcesof every map it loads. Index maps only havesections, so it throws, the map is never cached, and both--enable-source-mapsandfindSourceMap()ignore it.This resolves the
sourcesof each section's map instead, using that map'ssourceRoot. Test runner coverage reads the same top-level field and would hit the same error once these maps load, so it now walks the sections too.