Skip to content

deps: update googletest to 988ea2c1798de7779f656df2281dd36d6039a17a #66652

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
nodejs-github-bot wants to merge 1 commit into
base: main
Choose a base branch
from
+3 −3
Open

deps: update googletest to 988ea2c1798de7779f656df2281dd36d6039a17a #66652

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion deps/googletest/include/gtest/internal/gtest-param-util.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -601,7 +601,7 @@ class [[nodiscard]] ParameterizedTestSuiteInfo

MakeAndRegisterTestInfo(
test_suite_name, test_name.c_str(),
nullptr, // No type parameter.
/*type_param=*/nullptr, // No type parameter.
PrintToString(param).c_str(), test_info->code_location,
GetTestSuiteTypeId(),
SuiteApiResolver<TestSuite>::GetSetUpCaseOrSuite(file, line),
Expand Down
2 changes: 1 addition & 1 deletion deps/googletest/src/gtest-filepath.cc
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -325,7 +325,7 @@ FilePath FilePath::GenerateUniqueFileName(const FilePath& directory,
// This does NOT check that a directory (or file) actually exists.
bool FilePath::IsDirectory() const {
return !pathname_.empty() &&
IsPathSeparator(pathname_.c_str()[pathname_.length() - 1]);
IsPathSeparator(pathname_[pathname_.length() - 1]);
}

// Create directories so that path exists. Returns true if successful or if
Expand Down
2 changes: 1 addition & 1 deletion deps/googletest/src/gtest-port.cc
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1143,7 +1143,7 @@ static std::string FlagToEnvVar(const char* flag) {

Message env_var;
for (size_t i = 0; i != full_flag.length(); i++) {
env_var << ToUpper(full_flag.c_str()[i]);
env_var << ToUpper(full_flag[i]);
}

return env_var.GetString();
Expand Down
Loading