Skip to content

test: update WPT for url to b1a3daad99 - #66651

Open
nodejs-github-bot wants to merge 1 commit into
mainfrom
actions/update-url-wpt
Open

nodejs-github-bot wants to merge 1 commit into
mainfrom
actions/update-url-wpt

Conversation

@nodejs-github-bot

Copy link
Copy Markdown
Collaborator

This is an automated update of the WPT for url to web-platform-tests/wpt@b1a3daa.

@nodejs-github-bot nodejs-github-bot added the test Issues and PRs related to Node.js core tests and test infrastructure. label Oct 11, 2026
@nodejs-github-bot

Copy link
Copy Markdown
Collaborator Author

Review requested:

  • @nodejs/url
  • @nodejs/web-standards

@nodejs-github-bot nodejs-github-bot added the needs-ci PRs that need a full CI run. label Oct 11, 2026
@codecov

codecov Bot commented Oct 11, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 90.46%. Comparing base (04bd737) to head (f875281).

Additional details and impacted files
@@            Coverage Diff             @@
##             main   #66651      +/-   ##
==========================================
- Coverage   90.47%   90.46%   -0.01%     
==========================================
  Files         791      791              
  Lines      277097   277097              
  Branches    53277    53275       -2     
==========================================
- Hits       250696   250688       -8     
- Misses      16813    16822       +9     
+ Partials     9588     9587       -1     

see 33 files with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@aduh95

aduh95 commented Oct 11, 2026

Copy link
Copy Markdown
Contributor
/home/runner/work/node/node/node/test/common/wpt.js:1166
        throw new Error(
        ^

Error: Found 1 unexpected failures. Consider updating test/wpt/status/url.cjs for these files:
IdnaTestV2.any.html
    at process.<anonymous> (/home/runner/work/node/node/node/test/common/wpt.js:1166:15)
    at process.emit (node:events:526:24)

Node.js v27.0.0-pre
--- stdout ---

lpinca
lpinca previously approved these changes Oct 11, 2026
sleeyax added a commit to sleeyax/paseo-plugins that referenced this pull request Oct 12, 2026
…ent on Authored by me

GitHub's `latestReviews` gives a reviewer's latest review of any kind, so a comment after an approval or a change request hid the verdict.
Each reviewer's verdict now comes from `latestOpinionatedReviews`, and they read as commented only when they gave none.
That list leaves dismissed reviews out, so a push dismissal is read from its event, by reviewer, and holds until they give a newer verdict.
Checked read-only on public PRs: cli/cli#14475 shows COMMENTED in `latestReviews` and APPROVED in `latestOpinionatedReviews`, and nodejs/node#66651 shows a dismissed review in the first and nothing in the second.

Refs #143

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

needs-ci PRs that need a full CI run. test Issues and PRs related to Node.js core tests and test infrastructure.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants