Repository navigation
馃 User test baselines have changed - #26712
Closed
TypeScript Bot (typescript-bot) wants to merge 1 commit into
Closed
TypeScript Bot (typescript-bot) wants to merge 1 commit into
TypeScript Bot (typescript-bot) wants to merge 1 commit into
Conversation
TypeScript Bot (typescript-bot)
force-pushed
the
user-update-20180702
branch
from
August 28, 2018 13:34
6914a61 to
f66fcbe
Compare
Nathan Shively-Sanders (sandersn)
requested changes
Aug 28, 2018
Nathan Shively-Sanders (sandersn)
left a comment
Member
There was a problem hiding this comment.
Anders Hejlsberg (@ahejlsberg)
Looks like #26698 incorrectly removed a couple of good errors in unions. Specifically, chrome-devtools-frontend has code equivalent to this:
class C {
constructor(descriptors: (string | symbol | string[])[][]) {
for (var i = 0; i < descriptors.length; ++i) {
this[descriptors[i][1]] = // ...... more code here
}
}This previously gave the error "string[] cannot be used as an index type", which seems correct to me.
| Index signature is missing in type '{}'. | ||
| node_modules/chrome-devtools-frontend/front_end/host/InspectorFrontendHost.js(407,19): error TS2694: Namespace 'Adb' has no exported member 'Config'. | ||
| node_modules/chrome-devtools-frontend/front_end/host/InspectorFrontendHost.js(445,48): error TS2694: Namespace 'InspectorFrontendHostAPI' has no exported member 'ContextMenuDescriptor'. | ||
| node_modules/chrome-devtools-frontend/front_end/host/InspectorFrontendHost.js(471,12): error TS2538: Type 'string[]' cannot be used as an index type. |
There was a problem hiding this comment.
Looks like a result of #26698, possibly incorrect.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Please review the diff and merge if no changes are unexpected.
You can view the build log here.
cc Wesley Wigham (@weswigham) Nathan Shively-Sanders (@sandersn) Ryan Cavanaugh (@RyanCavanaugh)