Repository navigation
Conversation
mydea
added this pull request to stack #24913
October 12, 2026 14:08
Contributor
size-limit report 📦
|
mydea
marked this pull request as ready for review
October 13, 2026 07:44
mydea
requested review from
andreiborza and
isaacs
and removed request for
a team
October 13, 2026 07:44
andreiborza
approved these changes
Oct 13, 2026
mydea
force-pushed
the
feat/nitro-single-http-server-span
branch
2 times, most recently
from
October 14, 2026 06:48
9d4396f to
715d8cd
Compare
There was a problem hiding this comment.
Cursor Bugbot has reviewed your changes and found 1 potential issue.
❌ Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, enable autofix in the Cursor dashboard.
Reviewed by Cursor Bugbot for commit 715d8cd. Configure here.
| [SENTRY_ORIGIN]: 'auto.http.nitro.srvx', | ||
| [SENTRY_OP]: data.middleware ? MIDDLEWARE : HTTP_SERVER, | ||
| 'server.port': data.server.options.port, | ||
| 'server.port': getServerPort(data.server), |
There was a problem hiding this comment.
Hardcoded server.port attribute name
Low Severity
The srvx span still writes server.port as a string literal. @sentry/conventions/attributes already exports SERVER_PORT for this, and the Node HTTP server instrumentation uses that constant for the same field. Flagged because the review rules require conventions constants instead of hard-coded attribute names.
Triggered by project rule: PR Review Guidelines for Cursor Bot
Reviewed by Cursor Bugbot for commit 715d8cd. Configure here.
mydea
force-pushed
the
feat/nitro-single-http-server-span
branch
from
October 14, 2026 07:31
715d8cd to
525ca97
Compare
mydea
requested review from
nicohrubec and
s1gr1d
and removed request for
a team
October 14, 2026 07:31
mydea
removed this pull request from stack #24913
October 14, 2026 07:32
mydea
changed the base branch from
feat/nitro-anchor-both-on-h3
to
feat/nitro-single-integration
October 14, 2026 07:32
mydea
added this pull request to stack #25350
October 14, 2026 07:32
The srvx and h3 tracing channels each opened another http.server span below the one the runtime already creates, duplicating its attributes. srvx now only creates the root span when the runtime has not, and the h3 route handler gets a handler span that times the handler itself. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
mydea
force-pushed
the
feat/nitro-single-http-server-span
branch
from
October 14, 2026 07:44
525ca97 to
1cfc785
Compare
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
A Nitro request currently produces three nested
http.serverspans: the runtime's own (Nodehttp,Bun.serve,Deno.serve, Cloudflare's request wrapper), then one from srvx'ssrvx.requestchannel, then one from h3'sh3.requestroute channel. The nested two add nothing the root does not already carry: srvx only duplicates the URL and header attributes (with a wrongserver.port, the configured0rather than the bound port), and h3's route and params were already being copied onto the root.Now the root is the only
http.serverspan:http.serverspan, and only creates the root otherwise (e.g.@sentry/nodeon Bun, where no runtime instrumentation creates one).server.portnow reports the bound port in that case.handlerspan instead, the same op the Express integration uses for request handlers, so the time spent in the handler itself stays visible.This is a visible change for existing
@sentry/nitrousers: theauto.http.nitro.srvxandauto.http.nitro.h3http.serverspans go away, so queries or alerts on them need to move to the root span or thehandlerspan.🤖 Generated with Claude Code