Skip to content

replace parser with yargs-parser - #22779

Merged
dgp1130 merged 3 commits into
angular:masterfrom
alan-agius4:parser-clis
Mar 2, 2022
Merged

replace parser with yargs-parser#22779
dgp1130 merged 3 commits into
angular:masterfrom
alan-agius4:parser-clis

Conversation

@alan-agius4

@alan-agius4 alan-agius4 commented Feb 28, 2022 •
edited
Loading

Copy link
Copy Markdown
Collaborator

refactor(@angular-devkit/architect-cli): replace parser with yargs-parser

BREAKING CHANGE: camel case arguments are no longer allowed.

refactor(@angular-devkit/schematics-cli): replace parser with yargs-parser

BREAKING CHANGE: camel case arguments are no longer allowed.

Closes #13544, closes #12150, closes #22173 and closes #12165

refactor(@angular-devkit/benchmark): replace parser with yargs-parser

@alan-agius4 alan-agius4 changed the title refactor(@schemtics/angular): replace parser with yargs-parser refactor(@angular-devkit/schematics-cli): replace parser with yargs-parser Feb 28, 2022
@alan-agius4 alan-agius4 added the target: major This PR is targeted for the next major release label Feb 28, 2022
@alan-agius4 alan-agius4 changed the title refactor(@angular-devkit/schematics-cli): replace parser with yargs-parser replace parser with yargs-parser Feb 28, 2022
@alan-agius4
alan-agius4 requested a review from clydin February 28, 2022 12:57
@alan-agius4
alan-agius4 marked this pull request as ready for review February 28, 2022 12:57
clydin
clydin requested changes Feb 28, 2022
View reviewed changes
Comment thread packages/angular_devkit/schematics_cli/bin/schematics.ts Outdated
Comment thread packages/angular_devkit/architect_cli/bin/architect.ts Outdated
Comment thread packages/angular_devkit/benchmark/src/main.ts Outdated
Comment thread packages/angular_devkit/schematics_cli/bin/schematics.ts Outdated
Comment thread packages/angular_devkit/schematics_cli/bin/schematics.ts Outdated
Comment thread packages/angular_devkit/schematics_cli/bin/schematics.ts Outdated
@alan-agius4
alan-agius4 requested a review from clydin March 1, 2022 10:57
clydin
clydin reviewed Mar 1, 2022
View reviewed changes
Comment thread packages/angular_devkit/architect_cli/bin/architect.ts Outdated
@alan-agius4
refactor(@angular-devkit/schematics-cli): replace parser with yargs-p…
8d249e8 
…arser

BREAKING CHANGE: camel case arguments are no longer allowed.

Closes #13544, closes #12150, closes #22173
@alan-agius4
refactor(@angular-devkit/benchmark): replace parser with yargs-parser
40b4ac4
@alan-agius4
refactor(@angular-devkit/architect-cli): replace parser with yargs-pa…
680f4cc 
…rser

BREAKING CHANGE: camel case arguments are no longer allowed.
@alan-agius4 alan-agius4 added the action: merge The PR is ready for merge by the caretaker label Mar 2, 2022
@dgp1130
dgp1130 merged commit c7556b6 into angular:master Mar 2, 2022
@alan-agius4
alan-agius4 deleted the parser-clis branch March 2, 2022 18:36
@angular-automatic-lock-bot

angular-automatic-lock-bot Bot commented Apr 2, 2022

Copy link
Copy Markdown

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot Bot locked and limited conversation to collaborators Apr 2, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@clydin clydin clydin approved these changes

Assignees

No one assigned

Labels

action: merge The PR is ready for merge by the caretaker flag: breaking change target: major This PR is targeted for the next major release

Projects

None yet

Milestone

No milestone

3 participants

@alan-agius4 @clydin @dgp1130